Fix breakage in Ollama streaming tool calls and incorrect capability #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
ahyatt
temporarily deployed
to
Continuous Integration
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR fixes two related issues in Ollama's streaming tool call implementation: incorrect data handling in the tool collection method and incorrect capability reporting.
Key Changes:
- Fixed
llm-provider-collect-streaming-tool-usesto correctly handle a single tool call instead of trying to map over it as a list - Moved
streaming-tool-usecapability to only be reported when the model actually supportstool-use
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| llm-ollama.el | Corrected streaming tool call data extraction to handle single tool use and fixed capability reporting to only include streaming-tool-use when tool-use is supported |
| NEWS.org | Added changelog entries documenting the fixes for version 0.28.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #224