Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

The V2 domain API methods contained a hard-coded {customerId} string literal in URL paths that would be sent as-is to the GoDaddy API, causing requests to fail. The GoDaddy V2 API requires a UUID customerId (not the numeric shopperId from V1).

Changes

  • Added CustomerId property to ShopperResponse to capture the UUID from API responses
  • Updated RetrieveShopper method with optional includes parameter to fetch customerId via /v1/shoppers/{shopperId}?includes=customerId
  • Modified all 11 V2 domain methods to accept customerId as a required parameter:
    • GetDomainV2, ListDomainsV2, UpdateDomainV2, CancelDomainV2
    • PurchaseDomainV2, RenewDomainV2, TransferDomainV2
    • GetDNSRecordsV2, ReplaceDNSRecordsV2, AddDNSRecordsV2
    • UpdateDomainContactsV2

Usage

// Retrieve customerId (UUID) from shopperId
var shopper = await client.RetrieveShopper(
    new ShopperRetrieve { ShopperId = "12345" }, 
    includes: "customerId"
);
string customerId = shopper.CustomerId; // e.g., "295e3bc3-a3b9-4d95-aae5-edf41a994d13"

// Use with V2 endpoints
var domains = await client.ListDomainsV2(customerId, statuses: "ACTIVE");
var dns = await client.GetDNSRecordsV2(customerId, "example.com");

Previously:

// Would generate invalid URL: /v2/customers/{customerId}/domains/example.com
await client.GetDomainV2("example.com");

Now:

// Generates correct URL: /v2/customers/295e3bc3-a3b9-4d95-aae5-edf41a994d13/domains/example.com
await client.GetDomainV2(customerId, "example.com");

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits January 26, 2026 22:43
Co-authored-by: ahwm <20478373+ahwm@users.noreply.github.com>
Co-authored-by: ahwm <20478373+ahwm@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 26, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • developer.godaddy.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP Address feedback from PR #87 on V2 APIs implementation Fix hard-coded {customerId} placeholder in V2 domain API endpoints Jan 26, 2026
Copilot AI requested a review from ahwm January 26, 2026 22:47
@ahwm ahwm marked this pull request as ready for review January 26, 2026 22:52
@ahwm ahwm merged commit ea5f8de into v2-apis Jan 26, 2026
1 check passed
@ahwm ahwm deleted the copilot/sub-pr-87 branch January 26, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants