Add get_notes_from_clip and delete_notes_from_clip tools#83
Draft
meleyal wants to merge 1 commit intoahujasid:mainfrom
Draft
Add get_notes_from_clip and delete_notes_from_clip tools#83meleyal wants to merge 1 commit intoahujasid:mainfrom
meleyal wants to merge 1 commit intoahujasid:mainfrom
Conversation
Adds two new MCP tools: - get_notes_from_clip: reads all MIDI notes from a clip, returning pitch, start_time, duration, velocity, and mute for each note - delete_notes_from_clip: removes all MIDI notes from a clip without deleting the clip itself, enabling true overwrite when combined with add_notes_to_clip
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_notes_from_clip: reads all MIDI notes from a clip, returning each note's pitch, start_time, duration, velocity, and mute — sorted by start timedelete_notes_from_clip: removes all MIDI notes from a clip without deleting the clip itself, enabling true overwrite when combined withadd_notes_to_clipdelete_notes_from_clipis correctly dispatched on Ableton's main thread (alongsideadd_notes_to_clip) sinceclip.remove_notes()mutates Live's stateTest plan
get_notes_from_clipand verify notes are returned correctlydelete_notes_from_clipand verify the clip is empty but still existsadd_notes_to_clipafterdelete_notes_from_clipto confirm full overwrite works