Skip to content

Add files field to message_event and url_private to file type #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koonwen merged 1 commit into from
May 2, 2025
Merged

Add files field to message_event and url_private to file type #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/api_local.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ let default_files_res : Slack_t.file =
groups = [];
permalink = None;
permalink_public = None;
url_private = None;
}

let default_files_upload_res : Slack_t.files_upload_res = { ok = true; file = default_files_res }
Expand Down
2 changes: 2 additions & 0 deletions lib/slack.atd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ type file <ocaml attr="deriving make"> = {
~groups <ocaml default="[]">: string list;
?permalink: string nullable;
?permalink_public: string nullable;
?url_private: string nullable;
}

type files_upload_res = {
Expand Down Expand Up @@ -515,6 +516,7 @@ type message_event = {
ts: string;
?bot_id: string option;
?thread_ts: string option;
?files: file list nullable;
}

type link_shared_link = {
Expand Down
17 changes: 16 additions & 1 deletion lib_test/slack_payloads.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,22 @@ failed to update views: "Both external_id and view_id not found"
"channel": "C049XFXK286",
"user": "U04A3C2LC6N",
"text": "",
"ts": "1671595066.592719"
"ts": "1671595066.592719",
"files": [
{
"id": "F04FPJE4ES3",
"name": "-.txt",
"title": "Untitled",
"mimetype": "text/plain",
"filetype": "text",
"pretty_type": "Plain Text",
"user": "U04A3C2LC6N",
"size": 6458,
"permalink": "https://test-bot2-server.slack.com/files/SOME_FILE_URLtxt",
"permalink_public": "https://slack-files.com/SOME_FILE_URL",
"url_private": "https://files.slack.com/files-pri/SOME_FILE_URL/-.txt"
}
]
},
"event_id": "Ev04G41LD735",
"event_time": 1671595066
Expand Down
Loading