Skip to content

Conversation

@jrmhaig
Copy link

@jrmhaig jrmhaig commented Jun 3, 2016

No description provided.

@ahoward
Copy link
Owner

ahoward commented Jun 6, 2016

seems solid considering it bumps to 2.0.0. however. i haven't had the time to test of various platforms... given that the gem claims to be cross platform can we some people to confirm tests pass on

  • *nix
  • osx
  • windoze

??

@jrmhaig
Copy link
Author

jrmhaig commented Jun 10, 2016

I have checked it with OSX (10.9.5) and Linux (Ubuntu 14.04) on Rubies between 1.9.3 and 2.3 and a colleague has checked on Windows 10 with (I think) Ruby 2.3. However, the unit tests no longer run as they are actually testing the parse method, which I have merged into the from_system method. I will try to rewrite some unit tests to do the same coverage or similar. I will probably use rspec unless you particularly want to keep them as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants