Skip to content

Conversation

@kkrime
Copy link

@kkrime kkrime commented Nov 21, 2024

Adding workspace folder lsp support to project.nvim

Related issue #169

Related PR #170

@kkrime
Copy link
Author

kkrime commented Nov 21, 2024

@ahmedkhalf I think this is about ready, let me know what you think of the change

@ansidev
Copy link

ansidev commented Dec 29, 2024

It seems that the author is not actively working on this project (The last commit in the main branch is from the last year).

@robinknaapen
Copy link

I have for now used @kkrime their branch in my nvim config. Seems to work as intended.

Thanks for the work 🙏

@kkrime
Copy link
Author

kkrime commented Dec 29, 2024

@ansidev @robinknaapen this is a better fix https://github.com/ahmedkhalf/project.nvim/pull/147/files, but it's missing code to cover a corner case. I'm going to add the extra code to cover the corner case in the next few weeks, I'll post here once I've done it and tested it.

Once it's done I recommend you use it instead of this fix, but you can use this fix for the time being, it'll work.

@robinknaapen
Copy link

Thanks for the heads up, I'll watch that pull as well. And ofc @ahmedkhalf thanks for the contribution as well 🙏

@ansidev
Copy link

ansidev commented Dec 29, 2024

@kkrime Currently, I forked this repository to https://github.com/ansidev/project.nvim. Could you please create another pull request there? I will have a look at it!

@kkrime
Copy link
Author

kkrime commented Dec 29, 2024

@ansidev fo sure, it won't be any time soon, but I'll definitely keep you posted when I'm done

@kkrime
Copy link
Author

kkrime commented Jan 7, 2025

@robinknaapen @ansidev , use this: #178

@kkrime kkrime closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants