Skip to content

Ability to combine multiple groups#67

Open
mgzenitech wants to merge 6 commits intoahmadnassri:masterfrom
mgzenitech:master
Open

Ability to combine multiple groups#67
mgzenitech wants to merge 6 commits intoahmadnassri:masterfrom
mgzenitech:master

Conversation

@mgzenitech
Copy link

Not sure if you will want to merge this or not, but this literally allows consumers to have multiple groups combined, ie:

install-group dev,test,xxx

One caveat though (at least for my own needs I've dropped dependencies completely from package.json and rely instead of name+Dependencies, i.e. prodDependencies, devDependencies, coreDependencies and so on)

@ahmadnassri
Copy link
Owner

love it.

I'll review from my desktop later today and merge.

on the "dropping dependencies" I would not hardcore that, instead a --flag to I disable them, and perhaps an Env variable (so your use-case would still apply)

let me know if you're willing to make those adjustments in the PR (before I tackle them)

@mgzenitech
Copy link
Author

love it.

I'll review from my desktop later today and merge.

on the "dropping dependencies" I would not hardcore that, instead a --flag to I disable them, and perhaps an Env variable (so your use-case would still apply)

let me know if you're willing to make those adjustments in the PR (before I tackle them)

yeah, the flag/env var would probably work too. If you can just take my PR as base idea and modify it (I think also README file will need some mods too) to follow main philosophy of this project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants