Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns CI checks with local Overcommit hooks so CI runs the same pre-commit/pre-push validations described in issue #385.
Changes:
- Switch GitHub Actions CI to run
overcommit --run pre-commitandovercommit --run pre-pushinstead of bespoke Brakeman/RSpec steps. - Refactor Capybara app construction to reliably return the Rack app, and make the rate-limit feature spec self-contained by setting/restoring env/config inside the spec.
- Expand RuboCop/TrailingWhitespace exclusions to skip
.github/,docs/, andimages/.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
spec/spec_helper.rb |
Refactors Capybara app builder to return the Rack app (not the parse tuple) and exposes it for reuse. |
spec/features/rate_limit_feature_spec.rb |
Makes CI-only rate limit feature spec configure/restore env + Capybara app within hooks. |
.rubocop.yml |
Excludes additional non-app directories from RuboCop runs. |
.overcommit.yml |
Excludes additional directories from the TrailingWhitespace hook. |
.github/workflows/ruby.yml |
Runs Overcommit pre-commit and pre-push hooks in CI (replacing direct Brakeman/RSpec steps). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
We want to run the same checks in CI as in local dev, see #385
Closes #385
Description
Run precommit (pre-commit and pre-push, latter needs db),
replace existing tests run,
exclude some dirs in precommit
How Has This Been Tested?
in CI
Checklist