-
Notifications
You must be signed in to change notification settings - Fork 0
CI: fix live download test (Issue #18) #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
$Requesting review. Summary of changes in this PR:
CI is green. Please focus on:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the focused fixes — the YAML handling, scalar yq checks, token-gated live test, and clearer logs look solid overall.
Blocking change request:
- Linux mode check currently runs
chmod 600 "$ABS"before reading permissions. This masks whether the CLI respectedumask 077during file creation. Please remove thechmodand assert the mode of the freshly created file directly (expect 0600). This ensures deterministic enforcement and will catch regressions.
Recommended tweaks (non-blocking, for determinism/clarity):
- Use
yq -p=yamlconsistently when extractingIDfromOUT_SEARCH, and add an explicit pre-check that search returned results, e.g.yq -p=yaml -e ".data | type == \"!!seq\" and (.data | length) > 0"before reading.data[0].id. This avoids brittle failures if the query ever yields 0 hits. - In the Rust toolchain step, consider specifying
with: components: clippy, rustfmtto guarantee those components are available. CI is green, but explicitly requesting components improves reliability. - Optional: the hexdump currently targets
download.yaml. If you want a quick content sanity check of the downloaded asset itself, you could hexdump the first bytes of$ABSor printfile -b "$ABS"(JPEG/PNG), though the current existence/size checks are sufficient.
Once the permission check is corrected, I expect this to be good to approve.
noa-lucent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great after the updates. The Linux permission assertion now validates the mode directly; YAML parsing is deterministic with -p=yaml and a pre-check for non-empty results; scalar-only yq checks are in place; rustfmt/clippy components are explicitly requested; and logs are concise with helpful context.
Approving. ✅
$Replaces map/object yq comparisons with scalar checks; ensures deterministic file permissions on Linux; adds minimal debug.\n\nCloses #18