Fix main.py to generate valid JSON from input files#407
Open
hongjunki-405 wants to merge 1 commit intoagwaBom:mainfrom
Open
Fix main.py to generate valid JSON from input files#407hongjunki-405 wants to merge 1 commit intoagwaBom:mainfrom
hongjunki-405 wants to merge 1 commit intoagwaBom:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
path_to_file_list (around line XX)
Bug: opened the file with mode 'w' and returned undefined variable
lines.Fix: open the file in read mode ('r'), read all lines, strip trailing '\n' and return the list.
train_file_list_to_json (around line YY)
Bug: wrong escaping logic and incorrect JSON template
file.replace('\\', '\\')did nothing.if '/' or '"' in file:was always True.Fix: properly escape backslash, double quote and slash, then build a JSON line as
-
{"English":"...","German":"..."}.write_file_list (around line ZZ)
Bug: opened the output file with mode 'r' and only wrote '\n' without content.
Fix: open file in write mode ('w') and write each JSON string followed by a newline.