Fix file processing order and template usage#397
Open
eunsucho wants to merge 1 commit intoagwaBom:mainfrom
Open
Fix file processing order and template usage#397eunsucho wants to merge 1 commit intoagwaBom:mainfrom
eunsucho wants to merge 1 commit intoagwaBom:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
다음 두 가지 내용을 수정하였다
line 28: process_file의 경우 german_file에 대해 수행하므로 변수명이 기존 english_file에서 german_file로 변경되어야 한다.
line 30: append의 경우, template에서 start, mid, end의 순서대로 append되어야 하므로, template_start, template_mid, template_end의 순서대로 append되어야 올바른 순서대로 파일이 합쳐질 수 있다.