Open
Conversation
denzenn
commented
Nov 19, 2025
- There was missing code on line 5 and i completed the code and switched (w)write to (r)read .
- there were missing backslashes (\) on line 13, it was originally \ it meant nothing changed and four represents two backslashes.
- on line 20 template start began with {"German":" instead of {"English":" and i changed that.
- on line 28 It was meant to be german_file not english_file so i changed that.
- on line 30 you can see template_end template_mid template_start was not in the correct order.
- on line 36 it corresponds to write_file_list not read.
- on line 38 if it didn't have file it would have wrote empty lines.
- on line 46 and 48 train_file_list_to_json and path_to_file_list were swapped and could've messed up the whole code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.