Skip to content

Fixed lots of errors and missing code#396

Open
denzenn wants to merge 2 commits intoagwaBom:mainfrom
denzenn:main
Open

Fixed lots of errors and missing code#396
denzenn wants to merge 2 commits intoagwaBom:mainfrom
denzenn:main

Conversation

@denzenn
Copy link
Copy Markdown

@denzenn denzenn commented Nov 19, 2025

  1. There was missing code on line 5 and i completed the code and switched (w)write to (r)read .
  2. there were missing backslashes (\) on line 13, it was originally \ it meant nothing changed and four represents two backslashes.
  3. on line 20 template start began with {"German":" instead of {"English":" and i changed that.
  4. on line 28 It was meant to be german_file not english_file so i changed that.
  5. on line 30 you can see template_end template_mid template_start was not in the correct order.
  6. on line 36 it corresponds to write_file_list not read.
  7. on line 38 if it didn't have file it would have wrote empty lines.
  8. on line 46 and 48 train_file_list_to_json and path_to_file_list were swapped and could've messed up the whole code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant