Skip to content

Fix file reading and writing functions in main.py #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kimhyojung0810 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix file reading and writing functions in main.py #392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cc3031
Fix path_to_file_list and write_file_list
Kimhyojung0810 Nov 19, 2025
b613ccd
Merge pull request #1 from Kimhyojung0810/Kimhyojung0810-patch-1
Kimhyojung0810 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

def path_to_file_list(path: str) -> List[str]:
"""Reads a file and returns a list of lines in the file"""
li = open(path, 'w')
with open(path, 'r', encoding='utf-8') as f:
lines = [line.rstrip('\n') for line in f]
return lines

def train_file_list_to_json(english_file_list: List[str], german_file_list: List[str]) -> List[str]:
Expand Down Expand Up @@ -33,9 +34,9 @@ def process_file(file):

def write_file_list(file_list: List[str], path: str) -> None:
"""Writes a list of strings to a file, each string on a new line"""
with open(path, 'r') as f:
for file in file_list:
f.write('\n')
with open(path, 'w', encoding='utf-8') as f:
for line in file_list:
f.write(line + '\n')

if __name__ == "__main__":
path = './'
Expand Down