-
Notifications
You must be signed in to change notification settings - Fork 0
Promote DBot Dev #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote DBot Dev #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Vista application from Create React App to Vite, updates React from v18 to v19, and standardizes the build tooling and dependencies. The migration includes updating environment variable handling, test framework changes, and build configuration updates.
- Migration from Create React App to Vite build system
- Update from React v18 to v19 with related dependency updates
- Switch from Jest to Vitest for testing framework
Reviewed Changes
Copilot reviewed 28 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.js | New Vite configuration file replacing Create React App build system |
| package.json | Updated dependencies and scripts for Vite/Vitest migration |
| src/setupTests.js | Removed Jest-specific test setup |
| src/components/esrijs/MapView.test.jsx | Updated test syntax from Jest to Vitest |
| src/App.jsx | Updated environment variable access and import path |
| eslint.config.mjs | Simplified ESLint configuration using @ugrc/eslint-config |
| .env files | Renamed environment variables from REACT_APP_ to VITE_APP_ prefix |
| index.html | Updated HTML template for Vite with manual script import |
| .github/workflows/ | Updated CI/CD workflows to use pnpm instead of npm |
|
@steveoh Pinging you on this in case you missed the notification in the dbot avalanche. |
A lot of upgrades and standardizations. Waiting to hear back from DTS on Vista Citrix versions so that I know if I can do other arcgis-related upgrades (see note at the bottom of README).