generated from agrc/python
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: release v5.2.13-rc.1 #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
178d3f9 to
a7663ef
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 94.52% 95.69% +1.16%
==========================================
Files 7 7
Lines 1133 1254 +121
Branches 148 147 -1
==========================================
+ Hits 1071 1200 +129
+ Misses 52 44 -8
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a7663ef to
e413760
Compare
e413760 to
3beb295
Compare
3beb295 to
7a7fa72
Compare
Co-authored-by: steveoh <325813+steveoh@users.noreply.github.com>
Co-authored-by: steveoh <325813+steveoh@users.noreply.github.com>
Added 7 new test cases to improve coverage: - Success path with proper cleanup - Connection failure handling - Authentication failure handling - SFTP client creation failure - Exception during operations - Integration tests with real context manager Coverage increased from 94% to 96% Co-authored-by: steveoh <325813+steveoh@users.noreply.github.com>
Co-authored-by: steveoh <325813+steveoh@users.noreply.github.com>
- Fixed invalid escape sequences in regex patterns (extract.py lines 137, 195) Changed to raw strings (r"...") for proper regex syntax - Fixed FutureWarning for incompatible dtype assignment (load.py line 577) Changed from np.nan to pd.Series(dtype="object") for proper string/NaN handling All tests pass (369/370), coverage maintained at 96% Co-authored-by: steveoh <325813+steveoh@users.noreply.github.com>
Changed from pd.Series(dtype="object") to pd.Series([np.nan] * len(df), dtype="object", index=df.index) to properly handle index alignment and maintain np.nan for compatibility with tests All tests pass (369/370), coverage maintained at 96% Co-authored-by: steveoh <325813+steveoh@users.noreply.github.com>
- Added overwrite_existing_files boolean parameter to download_sftp_folder_contents (default=True) - Raises FileExistsError when overwrite_existing_files=False and file exists - Changed file counting to track downloaded files instead of directory count - Fixed path separator issues by using Path.as_posix() for cross-platform compatibility - Added 2 new tests for overwrite behavior - Updated all affected tests to handle new behavior All 371 tests pass, coverage maintained at 95% Co-authored-by: jacobdadams <38168030+jacobdadams@users.noreply.github.com>
Moved empty file list check inside first SFTP connection context to avoid opening second connection when no files to download All 371 tests pass, coverage maintained at 95% Co-authored-by: jacobdadams <38168030+jacobdadams@users.noreply.github.com>
7a7fa72 to
ed06dbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.2.13-rc.1 (2026-01-05)
⚠ BREAKING CHANGES
Features
Bug Fixes
This PR was generated with Release Please. See documentation.