-
Notifications
You must be signed in to change notification settings - Fork 0
Promote Dbot Updates #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote Dbot Updates #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR promotes Dbot updates by upgrading dependencies, migrating build scripts from npm to pnpm, and making small code style and formatting changes across the project. Key changes include removal of disabled ESLint comments in Station.jsx, updated dependency versions and build commands in package.json and CI workflows, and modified element locator selectors in end‐to‐end tests.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/location/Station.jsx | Removed ESLint disable comments and adjusted propTypes formatting. |
| src/components/location/PointDef.jsx | Minor formatting and dependency array updates. |
| src/components/habitat/Habitat.jsx | Trailing comma addition for style consistency. |
| src/components/DomainDrivenDropdown.jsx | Refactored to use react-query and updated async request handling. |
| src/components/DataGrid.jsx | Adjusted formatting and prop consistency. |
| src/components/ComboBox.jsx | Added an id property to the toggle button for clearer DOM identification. |
| package.json & CI workflows | Migrated from npm to pnpm and updated dependency versions. |
| e2e/submit_report.spec.js | Updated element selectors for expected DOM ids. |
| Other files | Minor changes for consistency and cleanup. |
Comments suppressed due to low confidence (2)
src/components/location/Station.jsx:56
- The removal of the ESLint disable comment for negated conditions may lead to new lint warnings. Please verify that the revised conditionals now comply with the project's style rules.
/* eslint-disable no-negated-condition */
e2e/submit_report.spec.js:51
- The updated locator for the toggle button appears inconsistent with the id format defined in ComboBox.jsx (using
${id}_button). Please verify that the element id in the DOM matches the selector used in the test so that the test will reliably identify the correct element.
await page.locator('[id="downshift-«r3»-toggle-button"]').click();
Co-authored-by: steveoh <sgourley@utah.gov>
The playwright test will likely fail. I don't know what's going on but don't feel like it's worth a deep dive into it. I've manually tested and it's good.