fix: recovery paths for PodSucceeded and PodFailed GameServer lifecycle#4480
Open
markmandel wants to merge 1 commit intoagones-dev:mainfrom
Open
fix: recovery paths for PodSucceeded and PodFailed GameServer lifecycle#4480markmandel wants to merge 1 commit intoagones-dev:mainfrom
markmandel wants to merge 1 commit intoagones-dev:mainfrom
Conversation
Both SucceededController and MissingPodController were purely event -driven with no fallback if a pod phase transition event was missed (e.g . during controller restart). This could cause GameServers to get stuck when their pod had already completed or failed and the Pod records weren't being garbage collected. - SucceededController: add GameServer informer UpdateFunc that re-checks pod phase on every ~30s resync, enqueuing any non-terminal GameServer whose pod is already in PodSucceeded state (mirrors the recovery pattern used by MissingPodController). - MissingPodController: extend the GS resync condition to also enqueue when the pod is in PodFailed state. HealthController already owns the primary (event-driven) path for PodFailed; this adds the recovery path for when that event is missed. Updates syncGameServer to pass through for failed pods and emit a distinct "Pod has failed" log and event. Signed-off-by: Mark Mandel <mark@compoundtheory.com>
markmandel
requested review from
igooch,
lacroixthomas,
peterzhongyi and
vicentefb
Collaborator
|
Build Succeeded 🥳 Build Id: e6916a7e-9c75-45a9-92fa-fac87b8434e3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Both SucceededController and MissingPodController were purely event -driven with no fallback if a pod phase transition event was missed (e.g . during controller restart). This could cause GameServers to get stuck when their pod had already completed or failed and the Pod records weren't being garbage collected.
SucceededController: add GameServer informer UpdateFunc that re-checks pod phase on every ~30s resync, enqueuing any non-terminal GameServer whose pod is already in PodSucceeded state (mirrors the recovery pattern used by MissingPodController).
MissingPodController: extend the GS resync condition to also enqueue when the pod is in PodFailed state. HealthController already owns the primary (event-driven) path for PodFailed; this adds the recovery path for when that event is missed. Updates syncGameServer to pass through for failed pods and emit a distinct "Pod has failed" log and event.
Which issue(s) this PR fixes:
Fixes 🤞🏻 TestGameServerPodCompletedAfterCleanExit
Special notes for your reviewer:
N/A