[db] Do not allocate additional key-values #1756#1757
Merged
michaelvlach merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to change the semantics of the reserve_capacity function in DbKeyValues from accepting an "additional capacity" parameter to accepting a "total capacity" parameter. The parameter is renamed from additional to len, and the internal logic changes from kvs.reserve(storage, kvs.len() + additional) to kvs.reserve(storage, len).
Changes:
- Renamed parameter from
additionaltoleninreserve_capacityfunction - Changed capacity calculation from
kvs.len() + additionalto justlen
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agnesoft
approved these changes
Feb 23, 2026
michaelvlach
deleted the
1756-db-do-not-allocate-additional-key-values
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.