feat: add hotkey to edit last message#927
Open
codedealer wants to merge 1 commit intoagnaistic:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a hotkey (arrow up) to edit the last message in the chat, a functionality present in most chat applications. This closes the ux loop: send message -> edit response -> apply changes -> send new message, allowing to complete it with keyboard only.
Implementation note
After some deliberation I worked around solidjs in a simple 10 lines js handler. The only viable alternative I see for this to be implemented the "right way" is to introduce a new field to the Message Store which seemed excessive for such a trivial thing.