Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 77.30% 77.36% +0.05%
==========================================
Files 67 67
Lines 3150 3145 -5
==========================================
- Hits 2435 2433 -2
+ Misses 715 712 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request primarily refactors deme initialization to use a unified DemeInitArgs object across multiple modules, while also updating plotting parameters and example notebook configurations.
- Refactored deme constructors in several modules (e.g., EA, DE, CMA, Local, Sobol, LHS, Shade) to accept a single DemeInitArgs parameter.
- Updated the landscape approximator and kriging plotting functions with new parameters and legend settings.
- Modified example notebook code to use updated sprout functions and adjusted evaluation limits.
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_tree_format.py | Updated test to import and use DemeInitArgs for CMADeme creation. |
| pyhms/tree.py | Replaced init_root with init_from_config and updated legend setup. |
| pyhms/demes/*.py | Unified deme constructors to use DemeInitArgs; updated variable names accordingly. |
| pyhms/demes/initialize.py | Changed init_from_config to use merged config-to-deme mapping with DemeInitArgs. |
| pyhms/cluster/landscape_approximator.py | Enhanced plateau contour plotting API. |
| pyhms/cluster/kriging.py | Adjusted threshold computation and legend configuration in contour plots. |
| examples/landscape_approximation.ipynb | Updated notebook parameters and sprout condition for better demo behavior. |
Files not reviewed (2)
- docs/custom_demes.rst: Language not supported
- docs/index.rst: Language not supported
Comments suppressed due to low confidence (2)
pyhms/cluster/kriging.py:91
- The threshold calculation has been changed from using the population median to the 10th quantile of z. Please verify that this change aligns with the intended behavior for plateau detection.
threshold = np.quantile(z, 0.1)
examples/landscape_approximation.ipynb:150
- The evaluation limit was reduced from 10000 to 1000, which may affect the tree run duration. Confirm that this change is intentional and does not negatively impact experimental outcomes.
global_stop_condition = SingularProblemEvalLimitReached(1000)
…S instead of pyhms/PyHMS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.