Skip to content

feat: improvements for GECCO workshop#89

Merged
WojtAcht merged 20 commits intomainfrom
improvements-for-paper
Mar 27, 2025
Merged

feat: improvements for GECCO workshop#89
WojtAcht merged 20 commits intomainfrom
improvements-for-paper

Conversation

@WojtAcht
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 21.05263% with 90 lines in your changes missing coverage. Please review.

Project coverage is 77.30%. Comparing base (9e62d69) to head (c484e65).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyhms/utils/print_tree.py 11.53% 46 Missing ⚠️
pyhms/tree.py 16.66% 40 Missing ⚠️
pyhms/stop_conditions/gsc.py 33.33% 2 Missing ⚠️
pyhms/demes/single_pop_eas/sea.py 83.33% 1 Missing ⚠️
pyhms/hms.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   79.96%   77.30%   -2.66%     
==========================================
  Files          67       67              
  Lines        3084     3150      +66     
==========================================
- Hits         2466     2435      -31     
- Misses        618      715      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Hubert-Guzowski Hubert-Guzowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to add comments to .ipynb files, so I will gather them in this comment.

  1. At least for me, when working with jupyter notebooks I am unable do import pyhms from the get go. The cwd is in the directory of the notebook (examples) and has to be adjusted
import sys
import os

sys.path.append(os.path.join(os.getcwd(), '..', ))
  1. The eps format is good for the inclusion in the paper, but requires installation of poppler. As an example for new user, it would be sufficient to show .png figures without additional configuration required

@WojtAcht WojtAcht changed the title feat: improvements for paper feat: improvements for GECCO workshop Mar 27, 2025
@WojtAcht
Copy link
Collaborator Author

Hard to add comments to .ipynb files, so I will gather them in this comment.

  1. At least for me, when working with jupyter notebooks I am unable do import pyhms from the get go. The cwd is in the directory of the notebook (examples) and has to be adjusted
import sys
import os

sys.path.append(os.path.join(os.getcwd(), '..', ))
  1. The eps format is good for the inclusion in the paper, but requires installation of poppler. As an example for new user, it would be sufficient to show .png figures without additional configuration required
  1. I added comment how to run the notebook on Google Colab (and I tested it).
  2. Ok, good point.

@WojtAcht WojtAcht merged commit 57ed1d2 into main Mar 27, 2025
1 of 3 checks passed
@WojtAcht WojtAcht deleted the improvements-for-paper branch March 27, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants