jake-shuaiyu structure #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrpred
reviewed
Oct 17, 2019
| my_group = | ||
| my_group = { | ||
| 'Jill' : { | ||
| 'relationships': { |
There was a problem hiding this comment.
Interesting method for generalizing relationships of any type. Will be very exstensible in the future. However, this you will run into problems when a person has more than one relationship with a single person (e.g. Zalika-friend, Zalika-cousin).
xrpred
reviewed
Oct 17, 2019
| 'job' : ['biologist'], | ||
| 'age' : 26 | ||
| }, | ||
| 'Zalika' : { |
There was a problem hiding this comment.
Nice that you use a person's name as a unique key.
xrpred
reviewed
Oct 17, 2019
| 'Jill' : 'friend', | ||
| 'Nash' : 'tenant' | ||
| }, | ||
| 'job' : ['artist'], |
There was a problem hiding this comment.
Allowing for a person to have zero or more than one job is also quite forward-thinking. Why not use a set though? (it's unlikely that a person will have multiple jobs with the same name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.