Skip to content

fix(rag): Add missing payload for ElasticsearchStore #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guanxuc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rag): Add missing payload for ElasticsearchStore #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/ElasticsearchStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ public class ElasticsearchStore implements VDBStoreBase, AutoCloseable {
private static final String FIELD_DOC_ID = "doc_id";
private static final String FIELD_CHUNK_ID = "chunk_id";
private static final String FIELD_CONTENT = "content";
private static final String FIELD_PAYLOAD = "payload";

private final String indexName;
private final int dimensions;
Expand Down Expand Up @@ -404,6 +405,10 @@ private Map<String, Object> mapToEsDocument(Document doc) {
DocumentMetadata meta = doc.getMetadata();
map.put(FIELD_DOC_ID, meta.getDocId());
map.put(FIELD_CHUNK_ID, meta.getChunkId());
Map<String, Object> customPayload = meta.getPayload();
if (customPayload != null && !customPayload.isEmpty()) {
map.put(FIELD_PAYLOAD, meta.getPayload());
}

// Serialize ContentBlock to JSON string to ensure safe storage/retrieval
try {
Expand Down
14 changes: 14 additions & 0 deletions ...ensions-rag-simple/src/test/java/io/agentscope/core/rag/store/ElasticsearchStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,20 @@ void testAddDimensionMismatch() throws VectorStoreException {
.verify();
}

@Test
@DisplayName("Should add documents with payload")
void testAddPayload() throws VectorStoreException {
store = createMockStoreForAdd(true);

TextBlock content = TextBlock.builder().text("Test content").build();
DocumentMetadata metadata =
new DocumentMetadata(content, "doc-1", "chunk-1", Map.of("k", "v"));
Document doc = new Document(metadata);
doc.setEmbedding(new double[TEST_DIMENSIONS]);

StepVerifier.create(store.add(List.of(doc))).verifyComplete();
}

// ==================== Search Method Tests ====================

@SuppressWarnings("unchecked")
Expand Down
Loading