Skip to content

fix(plan-notebook): buffer SSE stream lines to preserve order #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darkwu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(plan-notebook): buffer SSE stream lines to preserve order #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 43 additions & 18 deletions agentscope-examples/plan-notebook/src/main/resources/static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,34 +1103,59 @@ <h3>Subtasks</h3>
const reader = response.body.getReader();
const decoder = new TextDecoder();
let fullText = '';
// SSE can be split across chunks; keep an incremental buffer so we only
// process complete lines like `data: xxx`.
let buffer = '';

const handleData = (data) => {
if (data === '[PAUSED]') {
isPaused = true;
stopRequested = false;
controlState = 'continue';
updateControlUI();
if (!fullText) {
fullText = '(Plan updated - Review and edit the plan, then Continue)';
}
} else {
fullText += data;
}
contentDiv.textContent = fullText;
};

while (true) {
const { done, value } = await reader.read();
if (done) break;

const chunk = decoder.decode(value);
const lines = chunk.split('\n');
const chunk = decoder.decode(value, { stream: true });
buffer += chunk;

const lines = buffer.split('\n');
// Keep the last (possibly incomplete) line for the next chunk.
buffer = lines.pop();

for (const line of lines) {
if (line.startsWith('data:')) {
const data = line.substring(5).trim();
if (data) {
if (data === '[PAUSED]') {
isPaused = true;
stopRequested = false;
controlState = 'continue';
updateControlUI();
if (!fullText) {
fullText = '(Plan updated - Review and edit the plan, then Continue)';
}
} else {
fullText += data;
}
contentDiv.textContent = fullText;
}
const lineClean = line.trimEnd();
if (!lineClean.startsWith('data:')) continue;

const data = lineClean.substring(5).trim();
if (data) {
handleData(data);
}
}
}

// Flush any remaining decoded text and process the final buffered line
// (in case the stream ends without a trailing newline).
const remaining = decoder.decode();
if (remaining) buffer += remaining;
if (buffer) {
const lineClean = buffer.trimEnd();
if (lineClean.startsWith('data:')) {
const data = lineClean.substring(5).trim();
if (data) handleData(data);
}
}

if (!fullText) {
contentDiv.textContent = defaultMessage;
}
Expand Down
Loading