fix(manager): use HICLAW_PROXY_CONTAINER_PREFIX for cms tracing naming consistency#530
Draft
Jing-ze wants to merge 1 commit intoagentscope-ai:mainfrom
Draft
fix(manager): use HICLAW_PROXY_CONTAINER_PREFIX for cms tracing naming consistency#530Jing-ze wants to merge 1 commit intoagentscope-ai:mainfrom
Jing-ze wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
…sistency Align container-api.sh and CMS service name with the same HICLAW_PROXY_CONTAINER_PREFIX env var already used by docker-proxy, so custom prefixes propagate to container management and observability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Jing-ze
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-proxyalready readsHICLAW_PROXY_CONTAINER_PREFIXto validate container names, butcontainer-api.shandgenerate-worker-config.shhad the prefix hardcoded tohiclaw-worker-. This caused mismatches when a custom prefix was configured — container operations and CMS service names wouldn't align with the proxy's security rules.Test plan
HICLAW_PROXY_CONTAINER_PREFIXset) — verify worker containers and CMS traces still usehiclaw-worker-<name>HICLAW_PROXY_CONTAINER_PREFIX=custom-and verify container names and CMS service names both usecustom-<name>🤖 Generated with Claude Code