fix: security and robustness improvements (#116)#122
Open
lishanxiushanxiu wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix: security and robustness improvements (#116)#122lishanxiushanxiu wants to merge 1 commit intoagentscope-ai:mainfrom
lishanxiushanxiu wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
- Fix temporary file permissions in create-worker.sh (chmod 600) - Replace hardcoded test passwords with auto-generated secure values - Add .gitattributes for consistent line endings across platforms - Improve Makefile error handling with exit codes - Enhance timezone detection with additional fallback methods Security improvements: - Temporary MinIO policy files now have restricted permissions (600) - Test passwords are now auto-generated using openssl rand Robustness improvements: - Makefile tag target now fails fast on docker tag errors - Timezone detection adds date command fallback for macOS - Better handling of timezone abbreviation mapping
|
HiClaw Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
📊 CI Metrics Report
Summary
Generated by HiClaw CI on 2026-03-08 14:44:13 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 Security & Robustness Improvements
This PR fixes several security issues and improves code robustness:
Security Fixes
Temporary file permissions (
create-worker.sh)chmod 600to restrict MinIO policy file permissionsHardcoded test passwords (
run-all-tests.sh)testpassword123with auto-generated secure passwordsopenssl rand -hex 12for strong random generationRobustness Improvements
Cross-platform compatibility (
.gitattributes).gitattributesfile for consistent LF line endingsMakefile error handling
|| exit 1to tag target commandsTimezone detection (
hiclaw-install.sh)datecommand fallback for macOSreadlinkFiles Changed
manager/agent/skills/worker-management/scripts/create-worker.shtests/run-all-tests.shMakefileinstall/hiclaw-install.sh.gitattributes(new)BUGFIX_REPORT.md(new)Generated by HiClaw Manager Agent 🤖