fix: validate --page-size to prevent panic on negative values#410
Open
Bortlesboat wants to merge 1 commit intoagentregistry-dev:mainfrom
Open
fix: validate --page-size to prevent panic on negative values#410Bortlesboat wants to merge 1 commit intoagentregistry-dev:mainfrom
Bortlesboat wants to merge 1 commit intoagentregistry-dev:mainfrom
Conversation
Fixes agentregistry-dev#368 arctl skill list --page-size -1 causes a panic due to slice bounds out of range when the negative pageSize produces a negative end index at line 75. Add validation at the start of runList to reject non-positive values with a clear error message instead of panicking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #368
Summary
arctl skill list --page-size -1causes a panic due to slice bounds out of range when the negative pageSize produces a negative end index indisplayPaginatedSkills.Fix
Add validation at the start of
runListto reject non-positive values with a clear error message:Test plan
arctl skill list --page-size -1returns error instead of panicarctl skill list --page-size 0returns errorarctl skill list --page-size 5works normallyarctl skill list(default 15) works normally