fix: allow hyphenated tool names for MCP server compatibility #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `valid_name?/1` regex to permit hyphens in tool names, enabling integration with MCP servers like Notion that return hyphenated tool identifiers (e.g., `notion-get-users`). Closes agentjido#322 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update regex to require hyphen to be followed by alphanumeric chars - Add test case for trailing hyphen (invalid) - Fix formatting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
valid_name?/1regex to permit hyphens in tool namesnotion-get-users,get-response)Closes #322
Test plan
-invalid)🤖 Generated with Claude Code