fix(security): enable Claude OAuth refresh and tighten sandbox access#16
Merged
fix(security): enable Claude OAuth refresh and tighten sandbox access#16
Conversation
- Add write access to ~/Library/Keychains/login.keychain-db for token refresh - Replace broad ~/Library read with allowlist (Caches, Preferences, etc.) - Restrict write to session-specific $TMPDIR instead of all /var/folders - Deny access to sensitive Library paths (Cookies, Mail, Messages, Safari) - Enforce deny rules for critical sensitive paths in base profile
7bb841c to
6a46bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/Libraryread with allowlist of safe subdirectories/var/foldersDetails
Root cause: Claude stores OAuth tokens in macOS Keychain (
~/Library/Keychains/login.keychain-db). The sandbox allowed reading but not writing to the keychain, blocking token refresh after ~24 hours.Changes:
OAuth Fix: Added write access to
~/Library/Keychains/login.keychain-db(token refresh)Read Security: Replaced
~/Library(ALL data) with:~/Library/Caches/✓~/Library/Preferences/✓~/Library/Application Support/✓~/Library/Logs/✓~/Library/Frameworks/✓~/Library/Keychains/✓ (encrypted, requires Security framework ACL)~/Library/Developer/✓Now protected: Cookies, Mail, Messages, Safari, Calendar, Contacts, Accounts
Write Security: Restricted to session-specific temp:
/private/var/folders,/var/folders(ALL apps' temp)$TMPDIR(session-only)Test plan
sx claude -- claude /loginand verify token refresh workssx -- mktempto verify temp file creation still workscargo test)