Conversation
|
The author of this PR, siddhant-galileo, is not an activated member of this organization on Codecov. |
abhinav-galileo
left a comment
There was a problem hiding this comment.
PR Issues (Prioritized)
High
-
Commented-out code -
agent-detail.tsx:2551-2555andagent-detail.tsx:2514(// color='violet') - remove before merge -
Complex DOM querying in control-store (
modals/control-store/index.tsx:117-143) - fragile scroll container attachment relies on class name selectors that could break -
Initial tab redirect causes flash (
agent-detail.tsx:83-111) - redirects after render if stats exist, jarring UX
Medium
-
Magic strings for modal/submodal names -
"control-store","create","add-new","edit"scattered throughout - use constants -
Inconsistent close behavior (
use-modal-route.ts:98-121) -closeSubmodalfrom "create" goes to "add-new", but from other submodals closes entirely - may confuse users -
Missing dep in useEffect (
agent-detail.tsx:147-156) -selectedControlnot in dependency array, potential stale closure
Low
-
Unused destructured variables (
use-modal-route.ts:99) -_evaluatorand_controlIdextracted but unused, could simplify -
No tests for
useModalRoute- new hook with navigation logic has no test coverage
What Changed
URL-Based Search & Navigation
useQueryParamhook to sync search state with URL query parametersSearchInputcomponent with clear button and URL syncSticky Table Headers
ScrollAreawrappers in favor of table's native scrolling withmaxHeightpropMonitoring Page Improvements
TimeRangeSwitchcomponentagent-stats.tsxtoagents-monitoring.tsxCode Quality & Refactoring
LabelWithTooltipandStepNameInputcomponentsuseInfiniteScroll,useControlsInfinite,useAgentsInfinite)Technical Updates
@rungalileo/jupiter-ds@0.0.6,@emotion/is-prop-valid)DatesProviderto_app.tsxfor Mantine date componentsTesting
✅ All tests passing (84 integration tests, lint, TypeScript)