add domain/challenge to vp signing; only return jwt from signing#30
Merged
domleboss97 merged 1 commit intomainfrom Aug 13, 2025
Merged
add domain/challenge to vp signing; only return jwt from signing#30domleboss97 merged 1 commit intomainfrom
domleboss97 merged 1 commit intomainfrom
Conversation
venables
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signCredentialandsignPresentationto only return JWTs, rather than requiring aresolverto immediately parse the credential and return the parsed object. This more closely aligns with the intention of using jwt credentials. App logic can always callparseJwtCredentialto get the parsed credential.signPresentationto allow passing through achallengeand adomain.verifyPresentation.