Improve JWK types and methods, add did:jwks support#29
Merged
Conversation
domleboss97
approved these changes
Aug 12, 2025
| case "jwk": | ||
| verificationMethod.type = "JsonWebKey2020" | ||
| verificationMethod.publicKeyJwk = value | ||
| verificationMethod.publicKeyJwk = getPublicKeyJwk(value) |
Collaborator
There was a problem hiding this comment.
is there any way to enforce that the function itself never gets called with a jwk containing a private key, and not have to do that here? if not might be good to add a unit test for this.
Contributor
Author
There was a problem hiding this comment.
Great point. Turns out that method signature actually required it to be a PublicKeyJwk anyway, so I was able to drop this.
venables
force-pushed
the
venables/jwk-improvements
branch
from
91c2d41 to
6c94788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did:jwksresolver