Conversation
| @@ -1,5 +1,5 @@ | |||
| <h2 id="hot-buttons">{{ _("Häufige Aktionen") }}</h2> | |||
| <div class="btn-group"> | |||
| <div class="btn-group" style="padding-bottom: 1rem;"> | |||
There was a problem hiding this comment.
Please use the bootstrap utility classes (pb-N) instead of inline styles.
In the distant future I'd like to use tailwind, but that requires a build step (which we don't yet have in sipa)
There was a problem hiding this comment.
Inline CSS has some flaws, but all occurrences in SIPA have been removed. We should keep it this way.
So I agree please move it into a class ;)
agmes4
left a comment
agmes4
left a comment
There was a problem hiding this comment.
But I checked it on my smartphone and it definitively fixes the issues with the buttons and looks way better
I you have the time the payment qr code suffers from a similar problem, as it extends the window on smartphones. Would be very cool if you also fix this issue with the merge
And Thanks for your work ;)
There was a problem hiding this comment.
This should be removed from the pull request.
You probably did not add the submodules on purpose.
There was a problem hiding this comment.
Fixed: Refactored query client persistence setup to eliminate code duplication. Now uses a single implementation with conditional logic instead of duplicated code blocks.
| @@ -1,5 +1,5 @@ | |||
| <h2 id="hot-buttons">{{ _("Häufige Aktionen") }}</h2> | |||
| <div class="btn-group"> | |||
| <div class="btn-group" style="padding-bottom: 1rem;"> | |||
There was a problem hiding this comment.
Inline CSS has some flaws, but all occurrences in SIPA have been removed. We should keep it this way.
So I agree please move it into a class ;)
|
To fix the merge conflicts, just remove uv.lock and run |
4 participants
You're opening a pull request? Awesome!
Please make sure though you did the following (tick off everything you
already did):
developThis issue fixes #