Handle reversals for new imported transactions#701
Draft
FestplattenSchnitzel wants to merge 1 commit intodevelopfrom
Draft
Handle reversals for new imported transactions#701FestplattenSchnitzel wants to merge 1 commit intodevelopfrom
FestplattenSchnitzel wants to merge 1 commit intodevelopfrom
Conversation
Member
Author
|
Setting to draft b/c we should definitely add a test. |
Comment on lines
+224
to
+229
| amount = transaction.data["amount"].amount | ||
|
|
||
| # Reversal ("Storno") | ||
| if "R" in transaction.data.get("status", ""): | ||
| amount = -amount | ||
|
|
Collaborator
There was a problem hiding this comment.
Instead of doing that inline, we should provide an intermediate function which turns a MT940Transaction into a BankAccountActivity. For that, it needs from transaction.data the following fields:
applicant_ibanapplicant_binapplicant_namepurposeend_to_end_referenceamountguessed_entry_datedate
This should be a pure function
def activiity_from_transaction_data(
transaction_data: TDataTypedDict,
bank_account_id: int
) -> BankAccountActivity: ...where TDataTypedDict captures the aforementioned keys as a TypedDict.
We can then use a fixed mt940 dump of test data to check whether all the cases are handled properly without even having to touch the DB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #700