Conversation
| where module F = Bifunctor F | ||
|
|
||
| end-η♯ : {F G : Functor (P ×ᶜ (Category.op C ×ᶜ C)) D} (η : NaturalTransformation F G) | ||
| ⦃ ef : ∫ (F ♯) ⦄ ⦃ eg : ∫ (G ♯) ⦄ → NaturalTransformation (∫.E ef) (∫.E eg) |
There was a problem hiding this comment.
please don't use instance arguments. I'm fine with opaque and unfolding, but not these. Things are slow enough as it is, let's not make it worse.
There was a problem hiding this comment.
I'm not sure if the instances are making things slow here.
They make a lot of definitions nicer. For example, in Properties.agda there is the type
end-η-resp-∘ : (α : NaturalTransformation F G) (β : NaturalTransformation G H)
{{ef : ∫ F}} {{eg : ∫ G}} {{eh : ∫ H}} →
end-η (β ∘ᵥ α) ≈ end-η β ∘ end-η α
Stating each end here for end-η complicates the definition a lot, and I don't think that it makes things nicer. Using implicit arguments isn't possible either, since the only portion of the end that is solved uniquely is the apex.
The instance arguments work less well for parameterized ends, which is probably why you noticed it in this file and not the other.
|
Re: |
Yes, but I don't think this is all about reconstructing implicit arguments. It is also comparing terms. I reference #419 because one of the things that needs to be compared often is apices of ends |
|
I can't resolve all of the |
|
@JacquesCarette whenever you have the time, I would appreciate another look. I haven't changed everything that you suggested, but I left comments wherever I did not. |
|
...would it be possible to split this into several other PRs? It's very big and scary to look at for me (this isn't a requirement but I'd appreciate it) |
I can't split off too much, since github PRs can't depend on eachother. I split off some misc changes into #423 and #424 (will probably add to both of these later) |
|
Sorry for the slowness - was on vacation all last week. |
This PR is a collection of theorems and refactorings that were developed during my master's thesis.
This includes
Twist (F ∘ J)is iso toF ∘ Twist JEndF)Many definitions could be simplified if #419 is resolved.
Considerations
--lossy-unificationis currently necessary forCategories.Diagram.End.Fubini. I was hoping that refactoringEndFto use an opaqueend-ηcould fix this, but it does not.