Refonte - Trésorerie > Comptes banques > Télécharger les justificatifs #2046 #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgreb
changed the title
vgreb
force-pushed
the
refacto/accounting-bank-statements-download
branch
from
8bf0962 to
19a55c2
Compare
vgreb
force-pushed
the
refacto/accounting-bank-statements-download
branch
from
19a55c2 to
86ada9b
Compare
stakovicz
reviewed
Dec 30, 2025
|
|
||
| public function __invoke(Request $request): Response | ||
| { | ||
| $periodId = $request->query->has('periodId') && $request->query->get('periodId') ? (int) $request->query->get('periodId') : null; |
Contributor
There was a problem hiding this comment.
Suggested change
| $periodId = $request->query->has('periodId') && $request->query->get('periodId') ? (int) $request->query->get('periodId') : null; | |
| $periodId = $request->query->getInt('periodId', null); |
Collaborator
Author
There was a problem hiding this comment.
Ce n'est pas possible, getInt() doit forcément returner un int. Je peux au mieux utiliser getInt() et utiliser 0 en valeur par défaut mais ça va impliquer de modifier la fonction getCurrentPeriod pour gérer null et 0.
sources/AppBundle/Controller/Admin/Accounting/BankAccounts/DownloadStatementAction.php
Outdated
Show resolved
Hide resolved
sources/AppBundle/Controller/Admin/Accounting/BankAccounts/DownloadStatementAction.php
Show resolved
Hide resolved
vgreb
force-pushed
the
refacto/accounting-bank-statements-download
branch
from
86ada9b to
edbf037
Compare
vgreb
force-pushed
the
refacto/accounting-bank-statements-download
branch
from
edbf037 to
d3a8f51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.