Edit initWithUrl fun to use functional programming in (proInitWithUrl) function #161
Open
ahmedfolly wants to merge 1 commit intoafreakyelf:masterfrom
Open
Edit initWithUrl fun to use functional programming in (proInitWithUrl) function #161ahmedfolly wants to merge 1 commit intoafreakyelf:masterfrom
ahmedfolly wants to merge 1 commit intoafreakyelf:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for contributing to this project. This is your first pull request and we are so glad to have you onboard. We will review the request and get back to you soon. We love your contributions! Join our Discord community here to discuss this PR or ask questions.
afreakyelf
reviewed
Jan 18, 2025
| }) | ||
| } | ||
|
|
||
| fun proWithUrl( |
Owner
There was a problem hiding this comment.
What is proWithUrl? Mind adding comments and improve naming.
Author
There was a problem hiding this comment.
Updated version of initWithUrl fun.
Just pass to it function types as a @param.
Owner
There was a problem hiding this comment.
I am still confused with the naming.
Owner
|
Hi, would you mind cleaning up your PR and rebasing please. Thank you! |
Author
|
I will fix the naming issue
…On Sun, Apr 20, 2025, 00:50 Rajat Mittal ***@***.***> wrote:
Hi, would you mind cleaning up your PR and rebasing please. Thank you!
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMMPZ2XXFUJBEK27OZ4Q3322LHMTAVCNFSM6AAAAABPOS4QOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWHA4TIMZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*afreakyelf* left a comment (afreakyelf/Pdf-Viewer#161)
<#161 (comment)>
Hi, would you mind cleaning up your PR and rebasing please. Thank you!
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMMPZ2XXFUJBEK27OZ4Q3322LHMTAVCNFSM6AAAAABPOS4QOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWHA4TIMZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Please remove |
Author
|
Ok. Done
…On Mon, Apr 21, 2025, 20:16 Rajat Mittal ***@***.***> wrote:
Please remove .idea from your committed changes as well.
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMMPZ2NHLTASNLYIGBNDI322UYWRAVCNFSM6AAAAABPOS4QOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJZGE4DGNZXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*afreakyelf* left a comment (afreakyelf/Pdf-Viewer#161)
<#161 (comment)>
Please remove .idea from your committed changes as well.
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMMPZ2NHLTASNLYIGBNDI322UYWRAVCNFSM6AAAAABPOS4QOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJZGE4DGNZXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Hey @ahmedfolly, I still see .idea files and conflicts in your commit. Can you please exclude them and resolve them? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using functional programming in the initWithUrl function handles the states of downloading pdf easily, and makes the code of this function easy to understand.