Fix stylelint integration #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
force-pushed
the
fix-stylelint
branch
from
64c8044 to
571940e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stylelint integration that didn't work since years since we migrated to stylus and add it to GitHub CI.
We need postcss-styl to properly parse the .styl files. Some rules had to be disabled to be compatible with stylus (import-notation, no-invalid-position-at-import-rule, declaration-property-value-no-unknown that didin't know the unquote keyword), changed the stylus function for media query to simple css media query (with old prefix syntax, using 'media-feature-range-notation': 'prefix' in the config)
I disabled selector-class-pattern, selector-id-pattern, we won't change the case for some id or class. I also disabled no-descending-specificity too risky to change something here without careful review, and disabled value-keyword-case that did wrong auto fix.