Add theme selector #835
Merged
Add theme selector #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
force-pushed
the
add-theme-switcher
branch
from
672d738 to
2a5f40d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a theme selector with a choice of default theme + 24 new themes. This adds 77kB (14kB gzipped) to the bundle.
The themes comes from https://daisyui.com/docs/themes/
Some themes were not included because of low color ratio on some parts of the inspector.
All themes rules are prefixed with #aframeInspector to not have any conflicts with your site. The applied theme is also using data-theme attribute on #aframeInspector instead the html element to not conflict with your site.
The selected theme is saved to localStorage with the aframe-inspector-theme key.