Skip to content

Fix KeyError on TW class names by translating before lookup #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afq984 merged 1 commit into from
Apr 2, 2026
+31 −4
Merged

Fix KeyError on TW class names by translating before lookup #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions web/pobgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,46 @@
'Saboteur': (6, 3),
}

# TW class name -> EN class name
# Names come from the TW passive skill tree: https://pathofexile.tw/passive-skill-tree
# (look for the "classes" key in the inline JSON)
CLASS_MAP = {
'貴族': 'Scion',
'昇華使徒': 'Ascendant',
'遺守使徒': 'Reliquarian',
'野蠻人': 'Marauder',
'勇士': 'Juggernaut',
'暴徒': 'Berserker',
'酋長': 'Chieftain',
'遊俠': 'Ranger',
'守林人': 'Warden',
'銳眼': 'Deadeye',
'追獵者': 'Pathfinder',
'女巫': 'Witch',
'秘術家': 'Occultist',
'元素使': 'Elementalist',
'死靈師': 'Necromancer',
'決鬥者': 'Duelist',
'聖騎士': 'Templar',
'處刑者': 'Slayer',
'衛士': 'Gladiator',
'冠軍': 'Champion',
'聖堂武僧': 'Templar',
'判官': 'Inquisitor',
'聖宗': 'Hierophant',
'守護者': 'Guardian',
'暗影刺客': 'Shadow',
'貴族': 'Scion',
'刺客': 'Assassin',
'詐欺師': 'Trickster',
'破壞者': 'Saboteur',
}


def _translate_class(name):
return CLASS_MAP.get(name, name)


def get_encoded_tree(char, tree):
classId, ascendancyClass = CLASS_AND_ASCENDANCY_CLASS_IDS[char['class']]
classId, ascendancyClass = CLASS_AND_ASCENDANCY_CLASS_IDS[_translate_class(char['class'])]
head = [0, 0, 0, 6, classId, ascendancyClass, len(tree['hashes'])]
masteryEffects = []
for child in tree['mastery_effects']:
Expand All @@ -99,7 +126,7 @@ def Tree(char, tree):
# fmt: on
sockets = []
overrides = []
classId, ascendancyClass = CLASS_AND_ASCENDANCY_CLASS_IDS[char['class']]
classId, ascendancyClass = CLASS_AND_ASCENDANCY_CLASS_IDS[_translate_class(char['class'])]

for id, item in enumerate(tree['items'], 1):
x = item['x']
Expand Down
Loading