Skip to content

Comments

update#45

Merged
afonsoft merged 11 commits intodevelopfrom
main
Feb 17, 2026
Merged

update#45
afonsoft merged 11 commits intodevelopfrom
main

Conversation

@afonsoft
Copy link
Owner

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Problem:
- CI/CD was failing on Linux when trying to run .NET Framework 4.8 tests
- .NET Framework requires Windows environment, not Linux/Mono

Solution:
- Split tests by platform:
  - Ubuntu (Linux): Run only .NET 8.0 tests with --framework net8.0
  - Windows: Run .NET Framework 4.8 tests with --framework net48

Changes:
- Added build-windows job for Windows-specific tests
- Updated Linux tests to use --framework net8.0
- Updated job dependencies to include Windows build
- Maintained coverage reports on Linux only

Benefits:
- ✅ All target frameworks tested on appropriate platforms
- ✅ No more Mono dependency issues on Linux
- ✅ Faster CI pipeline with platform-specific jobs
- ✅ Better test isolation and reliability

🎯 CI/CD now supports all target frameworks correctly!
Problem:
- PowerShell was interpreting '--' as unary operators
- Multi-line commands with backslashes were causing syntax errors
- Error: 'Missing expression after unary operator --'

Solution:
- Convert multi-line commands to single-line format
- Remove backslashes and combine all parameters on one line
- Maintain same functionality with proper PowerShell syntax

Changes:
- dotnet test commands now use single-line format
- All parameters combined on one line for Windows PowerShell compatibility
- Preserved all test configuration and logging

🎯 Windows tests should now run without PowerShell syntax errors!
🔧 Fix PowerShell command formatting for Windows tests
Problem:
- 'dotnet list package --vulnerable' found multiple solution files
- Error: 'Found more than one solution file'
- Command failed without specifying which solution to use

Solution:
- Add MetarDecoder.sln parameter to the command
- Explicitly specify the solution file to scan
- Ensure consistent behavior across environments

Changes:
- dotnet list package MetarDecoder.sln --vulnerable --include-prerelease
- Targets the main solution file directly
- Removes ambiguity in multi-solution scenarios

🎯 Security scan will now run without file conflicts!
🔧 Fix security scan command to specify solution file
Problem:
- 'dotnet list package' doesn't accept solution file as direct argument
- Error: 'Unrecognized command or argument MetarDecoder.sln'
- Command syntax was incorrect for vulnerability scanning

Solution:
- Remove explicit solution file specification
- Let command auto-detect solution in current directory
- Use correct syntax for vulnerability checking

Changes:
- dotnet list package --vulnerable (without solution file)
- Command will automatically find and scan MetarDecoder.sln
- Simplified and more reliable execution

🎯 Security scan now uses correct .NET CLI syntax!
🔧 Fix security scan command syntax
@afonsoft afonsoft merged commit 6cf14ab into develop Feb 17, 2026
8 of 15 checks passed
@afonsoft
Copy link
Owner Author

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
🔚 Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant