This repository was archived by the owner on Apr 4, 2020. It is now read-only.
Grunt and NPM packaging #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' of undefined. Use standard self-executing anonymous function and remove strict mode. Resolve afiore#2 Signed-off-by: Evgeny Gusev <Evgeny.Gusev@quest.com> @shonzilla amended the comment to improve readability.
Remove __defineGetter__ and replace by getLength function. Remove indexOf because IE 8 does not have Array.prototype.indexOf method. Signed-off-by: Evgeny Gusev <Evgeny.Gusev@quest.com> @shonzilla amended the comment to improve readability.
Signed-off-by: Evgeny Gusev <Evgeny.Gusev@quest.com> @shonzilla amended the comment to improve readability.
Signed-off-by: Evgeny Gusev <Evgeny.Gusev@quest.com> @shonzilla amended the comment to improve readability.
Signed-off-by: Evgeny Gusev <Evgeny.Gusev@quest.com> @shonzilla amended the comment to improve readability.
Signed-off-by: Evgeny Gusev <Evgeny.Gusev@quest.com> @shonzilla amended the comment to improve readability.
Replaced the deprecated __defineGetter__() with the standard Object.defineProperty(). Should now work with IE 9+ instead of 11+ only. @shonzilla amended the comment to improve readability.
Now used Grunt to build docs and minify script Grunt now auto create minified version in /lib folder Added jsdoc notation to main script Grunt auto build JsDoc into /docs/doc folder Updated MIT-LICENSE.txt to respect all contributors Changed readme Added Wiki page In `traverseDown` method added optional second callback that called every time when node traverse ends. Updated `toString` method. Now it have parameter. If it set to `True` then data info will de printed for each node
|
I've just run into IE9 not liking defineGetter. Can this be merged in? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add grunt suppport and add npm package
arboreal.jsand also other few changes. You can seeit in wiki - https://github.com/vasiliyaltunin/arboreal.js/wiki