Conversation
added 2 commits
December 26, 2017 18:43
…ga == 'M'), and frequencyc (always 'Hz')
Owner
|
thanks, i will pull it a little later in the week. there have been so many
patches coming in thick and fast, i want to hand this over to someone with
faster git skills.
- f
…On Tue, Dec 26, 2017 at 11:42 PM, Bjørn Remseth ***@***.***> wrote:
Hi
I saw a misspelling of "transceiver" in the README file, so I fixed that.
While I was at it I looked through the code for the transceiver control,
and saw that the decadic prefixes Kilo and Mega were abbreviated
inconsistently and often incorrectly. As was the abbreviation for Hertz.
Edited these to be consistent, and to be conformant with:
- https://en.wikipedia.org/wiki/Metric_prefix
- https://en.wikipedia.org/wiki/Hertz
Only documentation files or fields were changed. No code that actually
compiles into anything
was touched during this edit.
Awsome project! Wonderful idea and fantastic execution. I may build one
myself :)
Best wishes. 73, de LA3LMA
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- Fixing typo
- Fix error mistakes with respecte to decadic prefixex (kilo == 'k',
mega == 'M'), and frequencyc (always 'Hz')
File Changes
- *M* README.md <https://github.com/afarhan/ubitx/pull/1/files#diff-0>
(2)
- *M* ubitx_20/ubitx_20.ino
<https://github.com/afarhan/ubitx/pull/1/files#diff-1> (202)
- *M* ubitx_20/ubitx_cat.ino
<https://github.com/afarhan/ubitx/pull/1/files#diff-2> (54)
- *M* ubitx_20/ubitx_menu.ino
<https://github.com/afarhan/ubitx/pull/1/files#diff-3> (121)
- *M* ubitx_20/ubitx_si5351.ino
<https://github.com/afarhan/ubitx/pull/1/files#diff-4> (23)
- *M* ubitx_20/ubitx_ui.ino
<https://github.com/afarhan/ubitx/pull/1/files#diff-5> (52)
Patch Links:
- https://github.com/afarhan/ubitx/pull/1.patch
- https://github.com/afarhan/ubitx/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAuLuOtuypZjFpmURm8a3kV_ePszpqfbks5tETcbgaJpZM4RM7OA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I saw a misspelling of "transceiver" in the README file, so I fixed that. While I was at it I looked through the code for the transceiver control, and saw that the decadic prefixes Kilo and Mega were abbreviated inconsistently and often incorrectly. As was the abbreviation for Hertz. Edited these to be consistent, and to be conformant to:
Only documentation files or fields were changed. No code that actually compiles into anything
was touched during this edit.
Awsome project! Wonderful idea and fantastic execution. I may build one myself :)
Best wishes. 73, de LA3LMA