Improve handling of errors when saving user settings #81
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for high CPU usage and audio dropouts. Includes a define to enable debugging messages.
Changed the level of rigor from FFTW_ESTIMATE to FFTW_MEASURE in order to resolve an issue where the FFTW library would sometime make a bad choice about the FFT algorithm to use. Added support for Wisdom files so that the FFTW library does not have to spend time picking the algorithm.
Changed the level of rigor from FFTW_ESTIMATE to FFTW_MEASURE in order to resolve an issue where the FFTW library would sometimes make a bad choice about the FFT algorithm to use. Added support for Wisdom files so that the FFTW library does not have to spend time picking the algorithm.
…ite user settings This change will cause the next attempt to write the user settings file when there is a file write error. For example, if the user decides to write protect the user settings file to reduce wear on the sd card, the code will detect the error and return with the settings_updated flag cleared. However the last_save_at variable was not getting updated during the handling of this error, so the function could be called again immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will cause the next attempt to write the user settings file when there is a file write error to be delayed by 30 seconds,
For example, if the user decides to write protect the user settings file to reduce wear on the sd card, the code will detect the error and return with the settings_updated flag cleared. However the last_save_at variable was not getting updated during the handling of this error, so the function could be called again immediately.