Skip to content

Change IsSnowflake to only look for a timestamp #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aevitas wants to merge 1 commit into from
Closed

Change IsSnowflake to only look for a timestamp #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/FlakeId/Extensions/IdExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,11 @@ public static long ToUnixTimeMilliseconds(this Id id)
/// <returns></returns>
public static bool IsSnowflake(this Id id)
{
// There's no way to guarantee the specified value is a snowflake.
// The closest we can get is by decomposing its components, and ensuring all of them are set
// to values that would be valid for a snowflake.
// Validates that the ID has a non-zero timestamp.
// Thread , Process, and Increment can legitimately be 0, so checking them for > 0 results in false negatives.
long timestamp = id >> TimestampOffset;
long thread = (id >> ThreadOffset) & Id.ThreadIdMask;
long process = (id >> ProcessOffset) & Id.ProcessIdMask;
long increment = id & Id.IncrementMask;

return timestamp > 0 && thread > 0 && process > 0 && increment >= 0;
return timestamp > 0;
}

/// <summary>
Expand Down
Loading