Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# separate terms of service, privacy policy, and support
# documentation.

name: Java CI with Maven
name: Maven

on:
workflow_dispatch:
Expand All @@ -18,18 +18,18 @@ on:

jobs:
build:

name: Pack lib and update graph
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
- name: Set up JDK 21
uses: actions/setup-java@v3
with:
java-version: '11'
java-version: '21'
distribution: 'temurin'
cache: maven
- name: Build with Maven
- name: Pack with Maven
run: mvn -B package --file pom.xml

# Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
Expand Down
20 changes: 13 additions & 7 deletions .github/workflows/sonarcloud.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# sonarcloud.io
# - Automatic Analysis - "Recommended"
# - "Even better" analysis are available through SonarQube Cloud's CI-based analysis :-P

name: SonarCloud
on:
workflow_dispatch:
Expand All @@ -11,27 +15,29 @@ jobs:
build:
name: Build and analyze
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
- name: Set up JDK 11
uses: actions/setup-java@v1
- name: Set up JDK 21
uses: actions/setup-java@v4
with:
java-version: 11
java-version: 21
distribution: 'temurin'
- name: Cache SonarCloud packages
uses: actions/cache@v1
uses: actions/cache@v3
with:
path: ~/.sonar/cache
key: ${{ runner.os }}-sonar
restore-keys: ${{ runner.os }}-sonar
- name: Cache Maven packages
uses: actions/cache@v1
uses: actions/cache@v3
with:
path: ~/.m2
key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
restore-keys: ${{ runner.os }}-m2
- name: Build and analyze
- name: Verify lib (all tests and integration checks)
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down
22 changes: 10 additions & 12 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,9 @@

<properties>
<!-- Dependency versions -->
<junit.jupiter.version>5.9.2</junit.jupiter.version>
<maven-surefire-plugin.version>2.22.2</maven-surefire-plugin.version>

<!-- Java 11 -->
<java.version>11</java.version>
<junit.jupiter.version>5.10.1</junit.jupiter.version>
<maven-surefire-plugin.version>3.3.0</maven-surefire-plugin.version>
<pluginversion.jacoco>0.8.11</pluginversion.jacoco>

<!-- Encoding -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down Expand Up @@ -47,14 +45,14 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.4.6</version>
<version>1.5.18</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.26</version>
<version>1.18.36</version>
<scope>provided</scope>
</dependency>

Expand All @@ -74,7 +72,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-junit-jupiter</artifactId>
<version>5.2.0</version>
<version>5.7.0</version>
<scope>test</scope>
</dependency>

Expand All @@ -87,7 +85,7 @@
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<version>3.24.2</version>
<version>3.25.0</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand All @@ -100,7 +98,7 @@
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.7</version>
<version>${pluginversion.jacoco}</version>
<executions>
<execution>
<id>prepare-agent</id>
Expand Down Expand Up @@ -140,8 +138,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>11</source>
<target>11</target>
<source>21</source>
<target>21</target>
</configuration>
</plugin>
</plugins>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@

/**
* The gson library converts simple byte arrays to ArrayList of Doubles...
* This lib either "bad" OR "can't guess the right type"
* This lib is either "bad" OR "can't guess the right type"
* <p>
* Bad:
* - Presence of solutions like <a href="https://gist.github.com/orip/3635246">this class</a> might have a reason.
* <p>
* Can't guess:
* - Deserialize a flied of type object is difficult.
* - Deserialize a field of type object is difficult.
*/
class GsonUtil {

Expand Down
Loading