Open
Conversation
…d atom labels in ACI; validate call injection inputs - Lexer: replace list_to_atom with list_to_existing_atom fallback to safe tag to prevent atom exhaustion - Include: restrict path traversal and absolute includes while allowing safe relatives under allowed roots - ACI: use binary labels in jsx:decode to avoid creating atoms from untrusted JSON - Call injector: add basic validation for names and single-line args/types/values to reduce injection surface Dialyzer: clean Tests: 565 tests, 0 failures
hanssv
requested changes
Aug 25, 2025
Member
hanssv
left a comment
hanssv
left a comment
There was a problem hiding this comment.
Thanks for the PR, it seems to contain a lot of useful stuff, both w.r.t documentation and code structure. But there is also things that seems entirely unrelated like a script for counting lines of code, and adding erlscripten as a sub-directory.
I think this PR needs to be split into more sizeable chunks in order to be accesible for reviewers. Preferrably should each PR tackle one issue, and not result in 4k lines of codes changed 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactoring