Skip to content

feat: add Ledger HW support#1685

Merged
davidyuk merged 2 commits intodevelopfrom
feature/ledger-support
Oct 2, 2022
Merged

feat: add Ledger HW support#1685
davidyuk merged 2 commits intodevelopfrom
feature/ledger-support

Conversation

@davidyuk
Copy link
Copy Markdown
Member

requires LedgerHQ/app-aeternity#13 to sign messages properly
ledger app is easy to build and run by guides:

Implementing this in SDK should deprecate https://github.com/aeternity/ledger-app-api

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 24, 2022

Codecov Report

Base: 84.10% // Head: 84.36% // Increases project coverage by +0.26% 🎉

Coverage data is based on head (8baedaa) compared to base (609555a).
Patch coverage: 84.69% of modified lines in pull request are covered.

❗ Current head 8baedaa differs from pull request most recent head 587e058. Consider uploading reports for the commit 587e058 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1685      +/-   ##
===========================================
+ Coverage    84.10%   84.36%   +0.26%     
===========================================
  Files           68       70       +2     
  Lines         2813     2911      +98     
  Branches       488      504      +16     
===========================================
+ Hits          2366     2456      +90     
+ Misses         261      258       -3     
- Partials       186      197      +11     
Impacted Files Coverage Δ
src/account/Ledger.ts 76.92% <76.92%> (ø)
src/account/LedgerFactory.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/utils/errors.ts 72.38% <0.00%> (+1.67%) ⬆️
src/channel/handlers.ts 70.62% <0.00%> (+1.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidyuk davidyuk force-pushed the feature/ledger-support branch 2 times, most recently from 4363eff to 8baedaa Compare September 24, 2022 19:19
@davidyuk davidyuk force-pushed the feature/ledger-support branch from 8baedaa to 587e058 Compare September 28, 2022 21:12
@davidyuk davidyuk merged commit af7f95b into develop Oct 2, 2022
@davidyuk davidyuk deleted the feature/ledger-support branch October 2, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant