feat: implement GraphQL interface to the middleware DB#2162
Draft
feat: implement GraphQL interface to the middleware DB#2162
Conversation
radrow
commented
Sep 30, 2025
Comment on lines
+3
to
+11
| # Ensure consistent node name for tests to match persisted DB owner (avoids :wrong_db_owner_node) | ||
| config :kernel, :distributed, [:'aeternity@localhost'] | ||
|
|
||
| # Do not start embedded node services for GraphQL/data correctness tests to avoid DB owner mismatch | ||
| # Use full node services in tests; ensure you invoke tests with: | ||
| # elixir --name aeternity@localhost -S mix test | ||
| config :ae_mdw, :start_node_services, true | ||
| config :ae_mdw, :sync, true | ||
|
|
Member
There was a problem hiding this comment.
Should this file be restored from master? Is there a reason for this change?
radrow
commented
Sep 30, 2025
docs/graphql.md
Outdated
Comment on lines
+122
to
+149
| --- | ||
| ## Security Considerations | ||
| - Depth & complexity limits are not yet enforced (add them before exposing publicly). | ||
| - Rate limiting is inherited from existing stack (none specific to GraphQL yet). | ||
| - User input is limited to IDs now; later additions must validate pagination cursors and filters. | ||
|
|
||
| --- | ||
| ## Contributing | ||
| Open a PR adding new fields and include: | ||
| - Schema changes | ||
| - Resolver(s) | ||
| - Unit tests (success + failure) | ||
| - Brief addition to this doc (Roadmap or new section) | ||
|
|
||
| --- | ||
| ## FAQ | ||
| **Why Absinthe instead of generating GraphQL from REST automatically?** | ||
| Absinthe offers strong flexibility, custom middleware, and Elixir-native patterns for batching and instrumentation. | ||
|
|
||
| **Will REST be deprecated?** | ||
| Not in the short term. GraphQL is additive and will target aggregate and selective data retrieval patterns first. | ||
|
|
||
| **How do I enable GraphiQL in prod for debugging?** | ||
| You should not. If absolutely necessary, guard it behind an env flag and temporary branch only. | ||
|
|
||
| --- | ||
| ## Support / Contact | ||
| File an issue in the repository with the `graphql` label for feature requests or bugs. |
radrow
commented
Nov 5, 2025
Comment on lines
+4
to
+28
| import_types(AeMdwWeb.GraphQL.Schema.Helpers.CustomTypes) | ||
|
|
||
| import_types(AeMdwWeb.GraphQL.Schema.Types.AccountTypes) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.BlockTypes) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.ContractTypes) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.NameTypes) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.StatsTypes) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.StatusTypes) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.TransactionTypes) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.ChannelTypes) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.Aex9Types) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.Aex141Types) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Types.OracleTypes) | ||
|
|
||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.AccountQueries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.BlockQueries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.ContractQueries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.NameQueries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.StatsQueries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.StatusQueries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.TransactionQueries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.ChannelQueries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.Aex9Queries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.Aex141Queries) | ||
| import_types(AeMdwWeb.GraphQL.Schema.Queries.OracleQueries) |
Member
Author
There was a problem hiding this comment.
Maybe allow import_types to take a list as well?
import_types([
AeMdwWeb.GraphQL.Schema.Types.AccountTypes,
AeMdwWeb.GraphQL.Schema.Types.BlockTypes
])Or maybe even multi-arg if possible
Member
There was a problem hiding this comment.
I have tried this, but it's not running. Maybe it's not possible to do so?
Member
|
@radrow For docs auto generation, first run the mdw locally, and then run |
Member
|
@radrow I have noticed this endpoint |
ghallak
reviewed
Nov 10, 2025
Member
There was a problem hiding this comment.
The entire file needs a rewrite.
ghallak
reviewed
Nov 10, 2025
ghallak
reviewed
Nov 10, 2025
Member
There was a problem hiding this comment.
@radrow the change here seems random. Is this an intended change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.