feat: add accounts count to delta and total stats#2109
Open
yaboiishere wants to merge 11 commits intomasterfrom
Open
feat: add accounts count to delta and total stats#2109yaboiishere wants to merge 11 commits intomasterfrom
yaboiishere wants to merge 11 commits intomasterfrom
Conversation
yaboiishere
force-pushed
the
account_stats
branch
from
cc18fbd to
a3fb5d0
Compare
edogggy
approved these changes
Mar 12, 2025
yaboiishere
force-pushed
the
account_stats
branch
from
799fa05 to
9cb45e4
Compare
sborrazas
reviewed
Mar 17, 2025
|
|
||
| defp get_accounts(state, from_txi, next_txi) do | ||
| state | ||
| |> Collection.stream(Model.Tx, {from_txi, next_txi}) |
Contributor
There was a problem hiding this comment.
I don't think this is right. Model.Tx keys are just txis, how is this key going to compare with a plain number?
Contributor
Author
There was a problem hiding this comment.
Oh, it is supposed to be the other clause of stream that accepts a key_boundary fixing it
| defp get_accounts(state, from_txi, next_txi) do | ||
| state | ||
| |> Collection.stream(Model.Tx, {from_txi, next_txi}) | ||
| |> Stream.take_while(&match?(txi when txi < next_txi, &1)) |
Contributor
There was a problem hiding this comment.
No need for matching here Stream.take_while(&(&1 < next_txi))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a long-ish migration around ~12 hours locally
resolves: #2040